Re: [PATCH v2] ACPI: resource: Add TongFang GM6BGEQ, GM6BG5Q and GM6BG0Q to irq1_edge_low_force_override[]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 10/8/23 14:16, Rafael J. Wysocki wrote:
> On Sat, Oct 7, 2023 at 10:51 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:

<snip>

>> I realize that I'm the architect of this whole mess, but delaying
>> these new quirks to 6.7 does not seem like a good idea to me.
>>
>> This fixes a serious problem (kbd not working pretty much makes
>> the whole laptop unusable under Linux at least on the road). With
>> a very small chance of regressions since this is DMI match base.
>>
>> Maybe we can just take all the resource.c DMI quirk changes
>> as fixes to 6.6 ?  I admit the:
>>
>> "ACPI: resource: Consolidate IRQ trigger-type override DMI tables"
>> "ACPI: resource: Drop .ident values from dmi_system_id tables"
>>
>> patches are not really bugfixes. But they too have a very low
>> chance of causing regressions.
>>
>> Regards,
>>
>> Hans
>>
>>
>> p.s.
>>
>> Note that "ACPI: resource: Skip IRQ override on ASUS ExpertBook B1402CBA"
>> should probably go as a fix to 6.6 regardless of the discussion since
>> that is a pure bugfix which applies cleanly on top of 6.6
> 
> That can be done.

Great thank you.

>> And the same goes for this (unrelated) drivers/acpi/ec.c patch:
>>
>> "ACPI: EC: Add quirk for the HP Pavilion Gaming 15-dk1xxx"
> 
> That can be done too.

Thank you again.

>> That too is a pure bugfix which IMHO should go to 6.6 as such.
> 
> But if you want the $subject patch to go into 6.6-rc, please rebase it
> on top of the latest 6.6-rc and resubmit.  It will not apply cleanly
> on top of the current linux-next, but I can handle the merge conflict.

That works for me, thank yuo. I've prepared a v3 which is based on
v6.6-rc1 so that it should apply cleanly for merging as fix for v6.6.

I'll send v3 out right after this email.

Regards,

Hans







[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux