HI, On 9/27/23 09:02, Bartosz Golaszewski wrote: > On Tue, Sep 26, 2023 at 5:27 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: >> >> On Tue, Sep 26, 2023 at 04:59:41PM +0200, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> >>> >>> Instead of acpi_get_and_request_gpiod() + gpiod_toggle_active_low(), use >>> temporary lookup tables with appropriate lookup flags. >> >> ... >> >>> + int3472->pled.gpio = skl_int3472_gpiod_get_from_temp_lookup( >>> + int3472->dev, path, agpio->pin_table[0], >>> + "int3472,privacy-led", polarity, >>> + GPIOD_OUT_LOW); >> >> Personally I found this style weird. I prefer to have longer line over >> the split on the parentheses. >> > > I in turn prefer this one. Checkpatch doesn't complain either way so > I'll leave it to the maintainers of this driver to decide. I'm fine with keeping this as is, using longer lines does not seem to make things better here. Regards, Hans
