On Tue, Sep 19, 2023 at 02:46:22PM +1000, Gavin Shan wrote: > The message needs to be split up into multiple lines to make ./scripts/checkpatch.pl > happy: > > pr_err_once(FW_BUG "CPU %u is online, but described " > "as not present or disabled!\n", pr->id); No. checkpatch is wrong on this point. Splitting the message like this hurts debuggability, because the message can no longer be grepped for. What James has done is perfectly fine. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
