Re: [PATCH 6/8] platform/x86: x86-android-tablets: Stop using gpiolib private APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 11, 2023 at 04:12:00PM +0200, Hans de Goede wrote:
> On 9/11/23 16:04, Bartosz Golaszewski wrote:

...

> >>>>>>>> +       lookup->dev_id = KBUILD_MODNAME;
> >>>>>>>> +       lookup->table[0].key = chip;
> >>>>>>>> +       lookup->table[0].chip_hwnum = pin;
> >>>>>>>> +       lookup->table[0].con_id = con_id;
> >>>>>>>> +       lookup->table[0].flags = active_low ? GPIO_ACTIVE_LOW : GPIO_ACTIVE_HIGH;

Actually you can use GPIO_LOOKUP() macro here as it provides a compound
literal.

	lookup->table[0] = GPIO_LOOKUP(...);

> Therefor I don't want to / cannot change the hashes of the commits,
> so a follow-up patch it is.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux