Oops one more note: On Tue, Sep 5, 2023 at 8:53 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > gpiochip_find() is going away as it's not hot-unplug safe. This platform > is not affected by any of the related problems as this GPIO controller > cannot really go away but in order to finally remove this function, we > need to convert it to using gpio_device_find() as well. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> (...) > + struct gpio_device *gdev; (...) > + gdev = gpio_device_find_by_label(OMAP_GPIO_LABEL); This leaves a reference to the gdev right? No scoped guard? If you leave a dangling reference intentionally I think it warrants a comment ("leaving a ref here so the device will never be free:ed"). Yours, Linus Walleij