Re: [PATCH v1 1/1] device property: Clarify usage scope of some struct fwnode_handle members

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 04, 2023 at 01:40:46PM +0300, Andy Shevchenko wrote:
> Most of the struct fwnode_handle members are for exclusive use with
> device links framework. Clarify this by adding a respective comment.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Yes, this is important clarification.

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
>  include/linux/fwnode.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
> index 5700451b300f..2a72f55d26eb 100644
> --- a/include/linux/fwnode.h
> +++ b/include/linux/fwnode.h
> @@ -41,6 +41,8 @@ struct device;
>  struct fwnode_handle {
>  	struct fwnode_handle *secondary;
>  	const struct fwnode_operations *ops;
> +
> +	/* The below is used solely by device links, don't use otherwise */
>  	struct device *dev;
>  	struct list_head suppliers;
>  	struct list_head consumers;
> -- 
> 2.40.0.1.gaa8946217a0b

-- 
heikki



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux