Re: [PATCH v3 0/3] ACPI: resource: Fix regressions from "Remove "Zen" specific match and quirks"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2023-08-09 10:55, Hans de Goede wrote:
Hi All,

Here is v3 of my series to address the regressions wrt PS/2 IRQs
not working on AMD zen models.

Changes in v3:
- Add links to more bug reports caused by a9c4a912b7dc to the commitmsg
- Also do the ZEN check for IRQ 12 (Reported-by August Wikerfors)
- Move the gsi != 1 && gsi != 12 check to inside the #ifdef CONFIG_X86,
   these being the i8042 IRQs is X86 specific and the "return true;" is
   always done for #ifndef CONFIG_X86 already
- Make acpi_int_src_ovr an array which keep track of the status
   of all legacy IRQs and not just IRQ 1

Changes in v2:
- Add 2 patches on top of the revert to avoid the revert causing
   other models which are known to need the override to regress.

As discussed in the v1 thread:
https://lore.kernel.org/linux-acpi/20230806151453.10690-1-hdegoede@xxxxxxxxxx/

This series adds a few fixes on top of the revert to avoid the revert
causing regressions on other AMD Zen systems where dropping the special
Zen behavior was known to fix things.

As also mentioned in the thread this is intended as a short term fix
for 6.4.y >= 6.4.7 and 6.5 to get all the systems which were working
fine before commit a9c4a912b7dc ("ACPI: resource: Remove "Zen"
specific match and quirks") to work again.

The long term plan is to see if we can read back what the BIOS
has actually programmed as IRQ trigger-type / polarity into
the IOAPIC.

Regards,

Hans

Hans de Goede (3):
   ACPI: resource: revert "Remove "Zen" specific match and quirks"
   ACPI: resource: Always use MADT override IRQ settings for all legacy
     non i8042 IRQs
   ACPI: resource: Honor MADT INT_SRC_OVR settings for IRQ1 on AMD Zen

  arch/x86/include/asm/acpi.h |  2 ++
  arch/x86/kernel/acpi/boot.c |  4 +++
  drivers/acpi/resource.c     | 52 +++++++++++++++++++++++++++++++++++++
  3 files changed, 58 insertions(+)


Thanks, I can confirm that this series fixes the regression caused by a9c4a912b7dc on Lenovo Yoga 7 14ARB7.

If relevant,
Tested-by: August Wikerfors <git@xxxxxxxxxxxxxxxxxx>

Regards,
August Wikerfors



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux