On Fri, Jul 28, 2023 at 12:49:07PM +0500, Muhammad Usama Anjum wrote: > On 7/28/23 11:54 AM, Tzung-Bi Shih wrote: > > Support official HID GOOG0016 for ChromeOS ACPI (see [1]). > > > > [1]: https://crrev.com/c/2266713 > > > > Signed-off-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx> > Looks good other than the documentation. > > Reviewed-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx> I didn't attach the R-b tag in v3 (https://patchwork.kernel.org/project/chrome-platform/patch/20230731024214.908235-1-tzungbi@xxxxxxxxxx/). Please review the documentation again. > > --- a/Documentation/ABI/testing/sysfs-driver-chromeos-acpi > > +++ b/Documentation/ABI/testing/sysfs-driver-chromeos-acpi > > @@ -1,4 +1,4 @@ > > -What: /sys/bus/platform/devices/GGL0001:*/BINF.2 > > +What: /sys/bus/platform/devices/GOOG0016:*/BINF.2 > Probably just replace the GGL0001:* with G* here and define the G* can be > GGL0001:* or GOOG0016:*. Fix it in v3 by appending a new line for "GOOG0016". > > --- a/Documentation/firmware-guide/acpi/chromeos-acpi-device.rst > > +++ b/Documentation/firmware-guide/acpi/chromeos-acpi-device.rst > > @@ -5,9 +5,8 @@ Chrome OS ACPI Device > > ===================== > > > > Hardware functionality specific to Chrome OS is exposed through a Chrome OS ACPI device. > > -The plug and play ID of a Chrome OS ACPI device is GGL0001. GGL is a valid PNP ID of Google. > > -PNP ID can be used with the ACPI devices according to the guidelines. The following ACPI > > -objects are supported: > > +The plug and play ID of a Chrome OS ACPI device is GGL0001 and the hardware ID is > > +GOOG0016. The following ACPI objects are supported: > Looks good. Probably GOOG0016 is HID which has higher preference over > GGL0001 which is CID if both are defined in firmware? Yes, I also guess so.
