On Fri, Jul 21, 2023 at 11:49 AM Cezary Rojewski <cezary.rojewski@xxxxxxxxx> wrote: > > On 2023-07-20 7:05 PM, Rafael J. Wysocki wrote: > > On Thu, Jul 20, 2023 at 7:01 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote: > >> > >> On Thu, Jul 20, 2023 at 11:15 AM Cezary Rojewski > >> <cezary.rojewski@xxxxxxxxx> wrote: > > ... > > >>>>> This approach generates a problem with undefined symbol "acpi_gbl_NHLT" when > >>>>> ACPI_NHLT is disabled. As nhlt.c is not built when said kconfig is disabled, > >>>>> symbol is never defined. > >>>>> > >>>>> Proposed solution - modify drivers/acpi/tables.c with: > >>>>> > >>>>> +#include <acpi/nhlt.h> > >>>>> + > >>>>> +struct acpi_table_nhlt *acpi_gbl_NHLT; > > > > No capitals in variable names, please. > > acpi_gbl_NHLT follows the path set by acpi_gbl_DSDT, _FADT and others. > Why would NHLT be an exception? Is this because it's not defined under > ACPICA? Yes, it is. ACPICA has its own rules, sort of.
