[PATCH] ACPI: fix undeclared symbols from saprse

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The building of drivers/acpi/acpica/utglobal.o is throwing
a number of sparse warnins about undeclared symbols. This is
due to defining DEFINE_ACPI_GLOBALS then making the macro
ACPI_INIT_GLOBAL() define it but never declaring the fact this
is an extern declared varible.

This is some of the sparse warnings that are being fixed here:

drivers/acpi/acpica/utglobal.c: note: in included file (through include/acpi/acpi.h):
./include/acpi/acpixf.h:104:1: warning: symbol 'acpi_gbl_enable_interpreter_slack' was not declared. Should it be static?
./include/acpi/acpixf.h:113:1: warning: symbol 'acpi_gbl_auto_serialize_methods' was not declared. Should it be static?
./include/acpi/acpixf.h:120:1: warning: symbol 'acpi_gbl_create_osi_method' was not declared. Should it be static?
./include/acpi/acpixf.h:126:1: warning: symbol 'acpi_gbl_use_default_register_widths' was not declared. Should it be static?
./include/acpi/acpixf.h:136:1: warning: symbol 'acpi_gbl_enable_table_validation' was not declared. Should it be static?
./include/acpi/acpixf.h:141:1: warning: symbol 'acpi_gbl_enable_aml_debug_object' was not declared. Should it be static?
./include/acpi/acpixf.h:149:1: warning: symbol 'acpi_gbl_copy_dsdt_locally' was not declared. Should it be static?
./include/acpi/acpixf.h:157:1: warning: symbol 'acpi_gbl_do_not_use_xsdt' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
---
Note, if this isn't the correct place to fix, where should this be
going?
---
 include/acpi/acpixf.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h
index 9ffdc0425bc2..8d69d1e39cd9 100644
--- a/include/acpi/acpixf.h
+++ b/include/acpi/acpixf.h
@@ -37,6 +37,7 @@
 	type name
 
 #define ACPI_INIT_GLOBAL(type,name,value) \
+	extern type name; \
 	type name=value
 
 #else
-- 
2.40.1




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux