Hi Conor, On Sun, Jul 2, 2023 at 8:42 PM Conor Dooley <conor@xxxxxxxxxx> wrote: > > Hey, > > On Sun, Jul 02, 2023 at 05:57:34PM +0800, Yunhui Cui wrote: > > When we bringup with coreboot on riscv, we need to obtain > > the entry address of SMBIOS through the FFI scheme. > > What do you need it for? RISC-V will be server-oriented, and the system needs to be managed based on SMBIOS. > > > > @@ -34,4 +35,7 @@ void __init ffi_acpi_root_pointer(void) > > void __init ffi_init(void) > > { > > ffi_acpi_root_pointer(); > > +#if CONFIG_FDT_FW_INTERFACE > > + ffi_smbios_root_pointer(); > > +#endif > > Please stub this function so that we don't need ifdeffery here. OK, I will update it on V3. Thanks, Yunhui