On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski <michal.wilczynski@xxxxxxxxx> wrote: > > To use new style of installing event handlers acpi_nfit_notify() needs > to be known inside acpi_nfit_add(). Move acpi_nfit_notify() upwards in > the file, so it can be used inside acpi_nfit_add(). > > Signed-off-by: Michal Wilczynski <michal.wilczynski@xxxxxxxxx> > --- > drivers/acpi/nfit/core.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > index 07204d482968..aff79cbc2190 100644 > --- a/drivers/acpi/nfit/core.c > +++ b/drivers/acpi/nfit/core.c > @@ -3312,6 +3312,13 @@ void acpi_nfit_shutdown(void *data) > } > EXPORT_SYMBOL_GPL(acpi_nfit_shutdown); > > +static void acpi_nfit_notify(struct acpi_device *adev, u32 event) > +{ > + device_lock(&adev->dev); > + __acpi_nfit_notify(&adev->dev, adev->handle, event); > + device_unlock(&adev->dev); > +} > + > static int acpi_nfit_add(struct acpi_device *adev) > { > struct acpi_buffer buf = { ACPI_ALLOCATE_BUFFER, NULL }; > @@ -3446,13 +3453,6 @@ void __acpi_nfit_notify(struct device *dev, acpi_handle handle, u32 event) > } > EXPORT_SYMBOL_GPL(__acpi_nfit_notify); > > -static void acpi_nfit_notify(struct acpi_device *adev, u32 event) > -{ > - device_lock(&adev->dev); > - __acpi_nfit_notify(&adev->dev, adev->handle, event); > - device_unlock(&adev->dev); > -} > - > static const struct acpi_device_id acpi_nfit_ids[] = { > { "ACPI0012", 0 }, > { "", 0 }, > -- Please fold this patch into the next one. By itself, it is an artificial change IMV.