Re: [PATCH v4 1/4] acpi: Move common tables helper functions to common lib

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2023/6/15 5:48, Dave Jiang wrote:
Some of the routines in ACPI driver/acpi/tables.c can be shared with
parsing CDAT. CDAT is a device-provided data structure that is formatted
similar to a platform provided ACPI table. CDAT is used by CXL and can
exist on platforms that do not use ACPI. Split out the common routine
from ACPI to accommodate platforms that do not support ACPI and move that
to /lib. The common routines can be built outside of ACPI if
FIRMWARE_TABLES is selected.

Link: https://lore.kernel.org/linux-cxl/CAJZ5v0jipbtTNnsA0-o5ozOk8ZgWnOg34m34a9pPenTyRLj=6A@xxxxxxxxxxxxxx/
Suggested-by: Rafael J. Wysocki <rafael@xxxxxxxxxx>
Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
---
v4:
- Add MAINTAINERS entry (Hanjun)
- Move __init_or_acpilib outside CONFIG_ACPI (0-day)
---
  MAINTAINERS              |    2
  drivers/acpi/Kconfig     |    1
  drivers/acpi/tables.c    |  173 ------------------------------------------
  include/linux/acpi.h     |   42 +++-------
  include/linux/fw_table.h |   43 ++++++++++
  lib/Kconfig              |    3 +
  lib/Makefile             |    2
  lib/fw_table.c           |  189 ++++++++++++++++++++++++++++++++++++++++++++++
  8 files changed, 251 insertions(+), 204 deletions(-)
  create mode 100644 include/linux/fw_table.h
  create mode 100644 lib/fw_table.c

diff --git a/MAINTAINERS b/MAINTAINERS
index 250518fc70ff..2145438e00dc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -371,6 +371,8 @@ F:	include/acpi/
  F:	include/linux/acpi.h
  F:	include/linux/fwnode.h
  F:	tools/power/acpi/
+F:	include/linux/fw_table.h
+F:	lib/fw_table.c

I think it's better in alphabetical order, others look
good to me,

Reviewed-by: Hanjun Guo <guohanjun@xxxxxxxxxx>

Thanks
Hanjun



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux