On 6/10/23 02:32, Rafael J. Wysocki wrote: > On Fri, Jun 9, 2023 at 5:49 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: >> >> The data type of struct acpi_device_id is defined in the >> mod_devicetable.h. It's suboptimal to require user with >> the almost agnostic code to include acpi.h solely for the >> macro that affects the data type defined elsewhere. >> >> Taking into account the above and for the sake of consistency >> move ACPI_DEVICE_CLASS() to mod_devicetable.h. >> >> Note, that with CONFIG_ACPI=n the ID table will be filed with data >> but it does not really matter because either it won't be used, or >> won't be compiled in some cases (when guarded by respective ifdeffery). >> >> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > or please let me know if you want me to apply this. Probably better if you take the whole thing. But if needed, I can take this through the ata tree. -- Damien Le Moal Western Digital Research