Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on 7736c431466abb54a2679dc257f739fddfa84295] url: https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/ACPI-x86-Add-pm_debug_messages-for-LPS0-_DSM-state-tracking/20230602-073044 base: 7736c431466abb54a2679dc257f739fddfa84295 patch link: https://lore.kernel.org/r/20230601232923.1248-1-mario.limonciello%40amd.com patch subject: [PATCH v3 1/4] include/linux/suspend.h: Only show pm_pr_dbg messages at suspend/resume config: powerpc-randconfig-r035-20230531 (https://download.01.org/0day-ci/archive/20230602/202306021344.JymS3JYg-lkp@xxxxxxxxx/config) compiler: powerpc-linux-gcc (GCC) 12.3.0 reproduce (this is a W=1 build): mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/5828d770a5f17c4028520050068fd3cdd13b80a1 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Mario-Limonciello/ACPI-x86-Add-pm_debug_messages-for-LPS0-_DSM-state-tracking/20230602-073044 git checkout 5828d770a5f17c4028520050068fd3cdd13b80a1 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=powerpc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/base/power/ kernel/power/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202306021344.JymS3JYg-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): drivers/base/power/wakeup.c: In function 'pm_print_active_wakeup_sources': >> drivers/base/power/wakeup.c:861:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 861 | if (!active && last_activity_ws) | ^ -- kernel/power/hibernate.c: In function 'disk_store': >> kernel/power/hibernate.c:1158:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1158 | if (!error) | ^ vim +/else +861 drivers/base/power/wakeup.c 074037ec79bea7 Rafael J. Wysocki 2010-09-22 841 bb177fedd348c9 Julius Werner 2013-06-12 842 void pm_print_active_wakeup_sources(void) a938da0682c248 Todd Poynor 2012-08-12 843 { a938da0682c248 Todd Poynor 2012-08-12 844 struct wakeup_source *ws; ea0212f40c6bc0 Thomas Gleixner 2017-06-25 845 int srcuidx, active = 0; a938da0682c248 Todd Poynor 2012-08-12 846 struct wakeup_source *last_activity_ws = NULL; a938da0682c248 Todd Poynor 2012-08-12 847 ea0212f40c6bc0 Thomas Gleixner 2017-06-25 848 srcuidx = srcu_read_lock(&wakeup_srcu); 2591e7b17c0d3f Madhuparna Bhowmik 2020-03-04 849 list_for_each_entry_rcu_locked(ws, &wakeup_sources, entry) { a938da0682c248 Todd Poynor 2012-08-12 850 if (ws->active) { 74a1dd86d1739e Stephen Boyd 2019-03-25 851 pm_pr_dbg("active wakeup source: %s\n", ws->name); a938da0682c248 Todd Poynor 2012-08-12 852 active = 1; a938da0682c248 Todd Poynor 2012-08-12 853 } else if (!active && a938da0682c248 Todd Poynor 2012-08-12 854 (!last_activity_ws || a938da0682c248 Todd Poynor 2012-08-12 855 ktime_to_ns(ws->last_time) > a938da0682c248 Todd Poynor 2012-08-12 856 ktime_to_ns(last_activity_ws->last_time))) { a938da0682c248 Todd Poynor 2012-08-12 857 last_activity_ws = ws; a938da0682c248 Todd Poynor 2012-08-12 858 } a938da0682c248 Todd Poynor 2012-08-12 859 } a938da0682c248 Todd Poynor 2012-08-12 860 a938da0682c248 Todd Poynor 2012-08-12 @861 if (!active && last_activity_ws) 74a1dd86d1739e Stephen Boyd 2019-03-25 862 pm_pr_dbg("last active wakeup source: %s\n", a938da0682c248 Todd Poynor 2012-08-12 863 last_activity_ws->name); ea0212f40c6bc0 Thomas Gleixner 2017-06-25 864 srcu_read_unlock(&wakeup_srcu, srcuidx); a938da0682c248 Todd Poynor 2012-08-12 865 } bb177fedd348c9 Julius Werner 2013-06-12 866 EXPORT_SYMBOL_GPL(pm_print_active_wakeup_sources); a938da0682c248 Todd Poynor 2012-08-12 867 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
