On Thu, May 25, 2023 at 6:23 PM Jonathan Cameron
<Jonathan.Cameron@xxxxxxxxxx> wrote:
>
> A cleanup in it's own right.
its ?
> This has the handy side effect of working for ACPI FW as well
> (unlike fwnode_irq_get() which works for ARM64 but not x86 ACPI)
...
> - irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
> + irq = platform_get_irq(pdev, 0);
It makes sense now not to even try a wrong IRQ, i.e.
if (irq < 0)
return irq;
+ blank line here.
> ret = devm_request_irq(&pdev->dev, irq, aspeed_i2c_bus_irq,
> 0, dev_name(&pdev->dev), bus);
> if (ret < 0)
--
With Best Regards,
Andy Shevchenko
