On Wed, May 24, 2023 at 9:28 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> On Tue, May 23, 2023 at 6:55 PM <andy.shevchenko@xxxxxxxxx> wrote:
> > Mon, May 22, 2023 at 03:00:32PM -0500, Mario Limonciello kirjoitti:
...
> > > - dev_dbg(&gpio_dev->pdev->dev,
> > > - "GPIO %d is active: 0x%x",
> > > - irqnr + i, regval);
> > > + pm_pr_dbg("GPIO %d is active: 0x%x",
> > > + irqnr + i, regval);
> >
> > Regression 1: The device is now omitted from the output.
>
> Right.
>
> > Regression 2: See https://stackoverflow.com/a/43957671/2511795
>
> Care to elaborate? I'm not sure what you mean exactly.
dev_dbg has 3 cases how it prints its content:
1/ With dynamic debug when it's enabled.
2/ With -DDEBUG if it's defined for the certain file(s) in the Makefile.
3/ No print.
pm_pr_dbg relies on CONFIG_PM_SLEEP_DEBUG, pm_debug_messages_on and
not on -DDEBUG. I haven't checked all relations between those 3, but
it seems to me that DEBUG is not equivalent to the others.
CONFIG_PM_SLEEP_DEBUG=n prevents printing with the dynamic debug on.
OTOH I dunno how this is relevant to the functionality of the driver
in question. Maybe it's okay to have such changes.
--
With Best Regards,
Andy Shevchenko
