Re: [PATCH 3/3] Documentation/arm64: Update ACPI tables from BBR

[Hanjun Guo <guohanjun@xxxxxxxxxx>]

Hi Jose,

On 2023/5/18 18:52, Jose Marinho wrote:
> The BBR specification requires (or conditionally requires) a set of ACPI
> tables for a proper working system.
> This commit updates:
> - the list of ACPI tables to reflect the contents of
> BBR version 2.0 (see https://developer.arm.com/documentation/den0044/g).
> - the list of ACPI tables in acpi_object_usage. This last update ensures
> that both files remain coherent.

Thanks for the update, some comments inline.

> Signed-off-by: Jose Marinho <jose.marinho@xxxxxxx>
> Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@xxxxxxx>
> ---
>   Documentation/arm64/acpi_object_usage.rst | 81 +++++++++++++++++++++--
>   Documentation/arm64/arm-acpi.rst          | 71 +++++++++++++++++---
>   2 files changed, 139 insertions(+), 13 deletions(-)
>
> diff --git a/Documentation/arm64/acpi_object_usage.rst b/Documentation/arm64/acpi_object_usage.rst
> index 484ef9676653..1da22200fdf8 100644
> --- a/Documentation/arm64/acpi_object_usage.rst
> +++ b/Documentation/arm64/acpi_object_usage.rst
> @@ -17,16 +17,37 @@ For ACPI on arm64, tables also fall into the following categories:
>   
>          -  Recommended: BERT, EINJ, ERST, HEST, PCCT, SSDT
>   
> -       -  Optional: BGRT, CPEP, CSRT, DBG2, DRTM, ECDT, FACS, FPDT, IBFT,
> -          IORT, MCHI, MPST, MSCT, NFIT, PMTT, RASF, SBST, SLIT, SPMI, SRAT,
> -          STAO, TCPA, TPM2, UEFI, XENV
> +       -  Optional: AGDI, BGRT, CEDT, CPEP, CSRT, DBG2, DRTM, ECDT, FACS, FPDT,
> +          HMAT, IBFT, IORT, MCHI, MPAM, MPST, MSCT, NFIT, PMTT, PPTT, RASF, SBST,
> +          SDEI, SLIT, SPMI, SRAT, STAO, TCPA, TPM2, UEFI, XENV
>   
> -       -  Not supported: BOOT, DBGP, DMAR, ETDT, HPET, IVRS, LPIT, MSDM, OEMx,
> -          PSDT, RSDT, SLIC, WAET, WDAT, WDRT, WPBT
> +       -  Not supported: AEST, APMT, BOOT, DBGP, DMAR, ETDT, HPET, IVRS, LPIT,

AEST is ARM Error Source Table, and it can be used for ARM platforms, so
I thinsk AEST is not belong to "Not supportted", "Optional" instead.

and APMT is the same.

> +          MSDM, OEMx, PDTT, PSDT, RAS2, RSDT, SLIC, WAET, WDAT, WDRT, WPBT

PDTT and RAS2 are now used for ARM too, please move it to Optional :)

[...]

>   
>          **Software LIcensing table**
> diff --git a/Documentation/arm64/arm-acpi.rst b/Documentation/arm64/arm-acpi.rst
> index 01171b10828a..49a69a1cc463 100644
> --- a/Documentation/arm64/arm-acpi.rst
> +++ b/Documentation/arm64/arm-acpi.rst
> @@ -170,7 +170,7 @@ hardware reduced mode must be set to zero.
>   
>   For the ACPI core to operate properly, and in turn provide the information
>   the kernel needs to configure devices, it expects to find the following
> -tables (all section numbers refer to the ACPI 6.1 specification):
> +tables (all section numbers refer to the ACPI 6.5 specification):
>   
>       -  RSDP (Root System Description Pointer), section 5.2.5
>   
> @@ -185,20 +185,75 @@ tables (all section numbers refer to the ACPI 6.1 specification):
>   
>       -  GTDT (Generic Timer Description Table), section 5.2.24
>   
> +    -  PPTT (Processor Properties Topology Table), section 5.2.30
> +
> +    -  DBG2 (DeBuG port table 2), section 5.2.6, specifically Table 5-6.
> +
> +    -  APMT (Arm Performance Monitoring unit Table), section 5.2.6, specifically Table 5-6.
> +
> +    -  AGDI (Arm Generic diagnostic Dump and Reset Device Interface Table), section 5.2.6, specifically Table 5-6.
> +
>       -  If PCI is supported, the MCFG (Memory mapped ConFiGuration
> -       Table), section 5.2.6, specifically Table 5-31.
> +       Table), section 5.2.6, specifically Table 5-6.
>   
>       -  If booting without a console=<device> kernel parameter is
>          supported, the SPCR (Serial Port Console Redirection table),
> -       section 5.2.6, specifically Table 5-31.
> +       section 5.2.6, specifically Table 5-6.
>   
>       -  If necessary to describe the I/O topology, SMMUs and GIC ITSs,
>          the IORT (Input Output Remapping Table, section 5.2.6, specifically
> -       Table 5-31).
> +       Table 5-6).
> +
> +    -  If NUMA is supported, the following tables are required:
> +
> +       - SRAT (System Resource Affinity Table), section 5.2.16
> +
> +       - SLIT (System Locality distance Information Table), section 5.2.17
> +
> +       - HMAT (Heterogeneous Memory Attribute Table), section 5.2.28

HMAT is for heterogeneous memory, so it's optional if no heterogeneous
memory in the hardware.

> +
> +    -  If the ACPI Platform Error Interfaces are required, the following
> +       tables are required:

Maybe "are conditionally required" is better, as SDEI, AEST and RAS2 are
optional I think.

Thanks
Hanjun