On 5/17/2023 11:35 AM, Hans de Goede wrote: > Hi all, Hi, > > On 5/17/23 09:56, Michal Wilczynski wrote: >> Currently drivers support ACPI event handlers by defining .notify >> callback in acpi_device_ops. This solution is suboptimal as event >> handler installer installs intermediary function acpi_notify_device as a >> handler in every driver. Also this approach requires extra variable >> 'flags' for specifying event types that the driver want to subscribe to. >> Additionally this is a pre-work required to align acpi_driver with >> platform_driver and eventually replace acpi_driver with platform_driver. >> >> Remove .notify callback from the acpi_device_ops. Replace it with each >> driver installing and removing it's event handlers. >> >> v3: >> - lkp still reported some failures for eeepc, fujitsu and >> toshiba_bluetooth, fix those >> v2: >> - fix compilation errors for drivers >> >> Michal Wilczynski (34): >> acpi: Adjust functions installing bus event handlers >> acpi/ac: Move handler installing logic to driver >> acpi/video: Move handler installing logic to driver >> acpi/battery: Move handler installing logic to driver >> acpi/button: Move handler installing logic to driver >> acpi/hed: Move handler installing logic to driver >> acpi/nfit: Move handler installing logic to driver >> acpi/thermal: Move handler installing logic to driver >> acpi/tiny-power-button: Move handler installing logic to driver >> hwmon: Move handler installing logic to driver >> iio/acpi-als: Move handler installing logic to driver >> platform/chromeos_tbmc: Move handler installing logic to driver >> platform/wilco_ec: Move handler installing logic to driver >> platform/surface/button: Move handler installing logic to driver >> platform/x86/acer-wireless: Move handler installing logic to driver >> platform/x86/asus-laptop: Move handler installing logic to driver >> platform/x86/asus-wireless: Move handler installing logic to driver >> platform/x86/classmate-laptop: Move handler installing logic to driver >> platform/x86/dell/dell-rbtn: Move handler installing logic to driver >> platform/x86/eeepc-laptop: Move handler installing logic to driver >> platform/x86/fujitsu-laptop: Move handler installing logic to driver >> platform/x86/lg-laptop: Move handler installing logic to driver >> platform/x86/panasonic-laptop: Move handler installing logic to driver >> platform/x86/system76_acpi: Move handler installing logic to driver >> platform/x86/topstar-laptop: Move handler installing logic to driver >> platform/x86/toshiba_acpi: Move handler installing logic to driver >> platform/x86/toshiba_bluetooth: Move handler installing logic to >> driver >> platform/x86/toshiba_haps: Move handler installing logic to driver >> platform/x86/wireless-hotkey: Move handler installing logic to driver >> platform/x86/xo15-ebook: Move handler installing logic to driver > Michal, I just stumbled over this patch-set while looking at > the lore.kernel.org linux-acpi archives... > > 17 of the patches here are for platform/surface or platform/x86 > so I must say that I'm quite surprised that > platform-driver-x86@xxxxxxxxxxxxxxx is not in the Cc for this patch-set? Sorry, that's my oversight, will fix as suggested > > And several of the pdx86 drivers at least also have individual driver > maintainers which should be Cc-ed. So that those maintainers can > hopefully help with reviewing reducing the workload for the subsystem > maintainers. > > Please make sure to run scripts/get_maintainer for all touched files > and put all the relevant people on the Cc. Either do so for a future > v4, or if there is no reason atm to do a v4, please resend v3 > with the Cc list extended. > > Regards, > > Hans Thank you ! Regards, Michał > > > > > >> virt/vmgenid: Move handler installing logic to driver >> acpi/bus: Remove installing/removing notify handlers from probe/remove >> acpi/bus: Remove redundant functions >> acpi/bus: Remove notify callback and flags >> >> drivers/acpi/ac.c | 14 +- >> drivers/acpi/acpi_video.c | 18 ++- >> drivers/acpi/battery.c | 14 +- >> drivers/acpi/bus.c | 53 ++----- >> drivers/acpi/button.c | 18 ++- >> drivers/acpi/hed.c | 6 +- >> drivers/acpi/nfit/core.c | 25 ++-- >> drivers/acpi/thermal.c | 20 ++- >> drivers/acpi/tiny-power-button.c | 18 +-- >> drivers/hwmon/acpi_power_meter.c | 15 +- >> drivers/iio/light/acpi-als.c | 23 ++- >> drivers/platform/chrome/chromeos_tbmc.c | 14 +- >> drivers/platform/chrome/wilco_ec/event.c | 19 ++- >> drivers/platform/surface/surfacepro3_button.c | 19 ++- >> drivers/platform/x86/acer-wireless.c | 22 ++- >> drivers/platform/x86/asus-laptop.c | 16 ++- >> drivers/platform/x86/asus-wireless.c | 24 ++-- >> drivers/platform/x86/classmate-laptop.c | 12 +- >> drivers/platform/x86/dell/dell-rbtn.c | 15 +- >> drivers/platform/x86/eeepc-laptop.c | 18 ++- >> drivers/platform/x86/fujitsu-laptop.c | 19 ++- >> drivers/platform/x86/lg-laptop.c | 12 +- >> drivers/platform/x86/panasonic-laptop.c | 17 ++- >> drivers/platform/x86/system76_acpi.c | 28 ++-- >> drivers/platform/x86/topstar-laptop.c | 16 ++- >> drivers/platform/x86/toshiba_acpi.c | 131 +++++++++--------- >> drivers/platform/x86/toshiba_bluetooth.c | 30 ++-- >> drivers/platform/x86/toshiba_haps.c | 9 +- >> drivers/platform/x86/wireless-hotkey.c | 23 ++- >> drivers/platform/x86/xo15-ebook.c | 11 +- >> drivers/virt/vmgenid.c | 30 ++-- >> include/acpi/acpi_bus.h | 10 +- >> 32 files changed, 457 insertions(+), 262 deletions(-) >>
