Hi Rafael, On Tue, May 16, 2023 at 12:12:13PM +0200, Rafael J. Wysocki wrote: > Hi Sakari, > > On Tue, May 16, 2023 at 10:57 AM Sakari Ailus > <sakari.ailus@xxxxxxxxxxxxxxx> wrote: > > > > Hi Rafael, > > > > On Mon, May 15, 2023 at 06:45:10PM +0200, Rafael J. Wysocki wrote: > > > On Wednesday, March 29, 2023 12:09:44 PM CEST Sakari Ailus wrote: > > > > Parse newly added ACPI _CRS CSI-2 descriptor for CSI-2 and camera > > > > configuration, associate it with appropriate devices and allocate memory for > > > > software nodes needed to create a DT-like data structure for drivers. > > > > > > It occurred to me, that there would be so many things I would like to change > > > in this patch, so it would be better to create my own version of it, which > > > is appended. > > > > > > It is based on > > > > > > https://patchwork.kernel.org/project/linux-acpi/patch/2694293.mvXUDI8C0e@kreacher/ > > > > > > that has just been posted. > > > > > > IIUC, the idea is to extract the ACPI handle for each resource source in every > > > _CRS CSI-2 resource descriptor and count how many times each handle appears in > > > a CSI-2 context, either because it is referenced from a _CRS CSI-2 resource > > > descriptor (as a "resource source"), or because its device object has CSI-2 > > > resource descriptors in _CRS. > > > > Correct. > > > > > > > > This allows a set of software nodes to be allocated for each of these handles. > > > > > > If I got that totally wrong, please let me know. Otherwise, I will rework the > > > remaining patches in the series to match this one. > > > > It seems about right. I mostly see renames, moving the code around, > > using the existing dependency list and then parsing sub-tree for _CRS CSI-2 > > objects right from the bus scan callback. > > > > It seems you've also moved the structs from internal.h to what is now > > called mipi-disco-imaging.c. > > No, I haven't moved anything in this direction, I've just dropped them. Ah, I think the struct was added to scan.c by the earlier patch. Indeed, by doing the _CRS CSI2 scanning right from the device scanning callback, it's probably possible to omit these. -- Regards, Sakari Ailus
