On Thu, Apr 20, 2023 at 12:23:11PM +0800, Baolu Lu wrote: > On 4/20/23 12:11 AM, Jason Gunthorpe wrote: > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > > index dbaf3ed9012c45..a82516c8ea87ad 100644 > > --- a/drivers/iommu/iommu.c > > +++ b/drivers/iommu/iommu.c > > @@ -569,7 +569,6 @@ static void __iommu_group_remove_device(struct device *dev) > > dev->iommu_group = NULL; > > goto out; > > Nit, given that below line has been removed, can above simply be a > loop break? Yes, that is much nicer Thanks, Jason