On 25/04/2023 05.20, Lukas Wunner wrote: > On Mon, Apr 24, 2023 at 03:46:57PM +0900, Hector Martin wrote: >> The Wi-Fi module in x86 Apple machines has a "module-instance" device >> property that specifies the platform type and is used for firmware >> selection. Its value is a string, so add support for string values in >> acpi_extract_apple_properties(). >> >> Reviewed-by: Lukas Wunner <lukas@xxxxxxxxx> >> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> >> Signed-off-by: Hector Martin <marcan@xxxxxxxxx> > > I was about to review this when I spotted my Reviewed-by tag above. > Turns out this was first submitted 16 months ago. Wow, time flies! > > https://lore.kernel.org/all/20211226182012.GA5527@xxxxxxxxx/ Yup, the original series was never merged and I've been pushing the brcmfmac bits piecewise over time instead... and then I completely forgot about this patch, which turns out to (now) be the last missing piece for WiFi to work on Apple T2 Macs :). - Hector
