> >> + } > >> + > >> +out: > >> + ACPI_FREE(out_obj); > >> + return output; > >> + > >> +err: > >> + ACPI_FREE(out_obj); > >> + return ERR_PTR(rc); > > > > Why not combine these with something like > > > > return IS_ERR(rc) ? ERR_PTR(rc) : output; > > > > I'm fine with leaving as it is, if this is common style for these > > sorts of ACPI functions. > > I'll combine it. But if I just set output to ERR_PTR(errno) for all the > error cases then we can just return output directly without checking? Excellent point. > > > > >> +} > >> +EXPORT_SYMBOL_NS_GPL(cxl_acpi_evaluate_qtg_dsm, CXL); > >
