Hi Hans, On Mon, Apr 17, 2023 at 11:11:28PM +0200, Hans de Goede wrote: > On some Cherry Trail devices the second PWM controller uses > 80862289 as ACPI HID, rather then using 80862288 as is done ACPI _HID (ditto in $subjet) > for both controllers on most models. > > Add the missing 80862289 ACPI HID, note this uses its own ACPI _HID > lpss_device_desc, without ".setup = bsw_pwm_setup" so that > the pwm_lookup is not added for it. > On devices where both controllers use the 80862288 HID bsw_pwm_setup() _HID > does a UID check to avoid registering the lookup for the second _UID > controller but that will not work here. > > Adding the missing id fixes the second PWM controller no longer > working after the entire LPSS1 island has been in D3 at least > once, which causes the contents of the LPSS private registers > to get lost. Adding the HID makes acpi_lpss restore these _HID > when the controller moves from D3 to D0. > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> With the above changes, feel free to add Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
