> To bundle the phy firmware parsing step within phx_device.c the commit > copies the required code from fwnode_mdio.c. After we converterd all > callers of fwnode_mdiobus_* to this new API we can remove the support > from fwnode_mdio.c. Why bundle the code? Why not call it in fwnode_mdio.c? The bundling in this patch makes it harder to see the interesting part of this patch, how the reset is handled. That is what this whole patchset is about, so you want the review focus to be on that. Andrew
