Hi Adnry,
On Tue, Mar 28, 2023 at 06:51:29PM +0300, Andy Shevchenko wrote:
> On Tue, Mar 28, 2023 at 01:12:59PM +0300, Sakari Ailus wrote:
> > Generate software nodes for driver use, based on MIPI DisCo for Imaging
> > definitions.
> >
> > During the (sub-)namespace walk, ACPI device nodes are created but the
> > drivers aren't probed for the devices yet. A convenient way to determine
> > which ACPI devices this applies to is to find a hierarchical data node that
> > begins with "mipi-img-port-". These devices need software nodes that need
> > to be present before probing, and can only be constructed once the related
> > _CRS CSI2 records have been parsed.
>
> ...
>
> > - static const char mipi_port_prefix[] = "mipi-img-port-";
> > - char mipi_port_name[sizeof(mipi_port_prefix) + 2];
> > + char mipi_port_name[sizeof(MIPI_IMG_PORT_PREFIX) + 2];
> >
> > if (snprintf(mipi_port_name, sizeof(mipi_port_name), "%s%u",
> > - mipi_port_prefix, port) >= sizeof(mipi_port_name)) {
> > + MIPI_IMG_PORT_PREFIX, port) >= sizeof(mipi_port_name)) {
>
> You are modifying lines you just brought by the previous patch. Why this mess?
>
> ...
>
> > -static void acpi_bus_handle_postpone(acpi_handle handle,
> > - struct list_head *head)
> > +static void acpi_bus_handle_postpone(acpi_handle handle, struct list_head *head)
>
> Unrelated change?
>
> ...
>
> > +/**
> > + * acpi_bus_device_postpone - Add an ACPI device to a given postponed list
> > + * @device: The ACPI device
> > + * @head: Postponed list head
> > + *
> > + * Add a given ACPI device to a list of ACPI objects for which the creation
> > + * of the device objects is to be postponed.
> > + */
> > +void acpi_bus_device_postpone(struct acpi_device *device,
> > + struct list_head *head)
>
> Taking into account above indentation, why not to have them on one line to
> begin with?
I'll address these for v8.
--
Kind regards,
Sakari Ailus
