On Fri, Mar 24, 2023 at 09:26:47AM +0000, Russell King (Oracle) wrote:
> fwnode_get_phy_mode() does not modify the fwnode argument, merely
> using it to obtain the phy-mode property value. Therefore, it can
> be made const.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Thank you!
> Signed-off-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
> ---
> Patch generated against net-next tree as that was where it was used and
> tested.
>
> drivers/base/property.c | 2 +-
> include/linux/property.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index 083a95791d3b..fcc0687f5529 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -895,7 +895,7 @@ EXPORT_SYMBOL_GPL(device_get_dma_attr);
> * 'phy-connection-type', and return its index in phy_modes table, or errno in
> * error case.
> */
> -int fwnode_get_phy_mode(struct fwnode_handle *fwnode)
> +int fwnode_get_phy_mode(const struct fwnode_handle *fwnode)
> {
> const char *pm;
> int err, i;
> diff --git a/include/linux/property.h b/include/linux/property.h
> index f7100e836eb4..d18c8cc17315 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -396,7 +396,7 @@ enum dev_dma_attr device_get_dma_attr(const struct device *dev);
> const void *device_get_match_data(const struct device *dev);
>
> int device_get_phy_mode(struct device *dev);
> -int fwnode_get_phy_mode(struct fwnode_handle *fwnode);
> +int fwnode_get_phy_mode(const struct fwnode_handle *fwnode);
>
> void __iomem *fwnode_iomap(struct fwnode_handle *fwnode, int index);
>
> --
> 2.30.2
>
--
With Best Regards,
Andy Shevchenko
