On Fri, Mar 24, 2023 at 08:58:54AM +0100, Uwe Kleine-König wrote:
> The loop
>
> for (i = 0; i < ACPI_NUM_NOTIFY_TYPES; i++) {
> if (handler_type & (i + 1)) {
> ...
> }
> }
>
> looks strange. Only with knowing that ACPI_NUM_NOTIFY_TYPES == 2 you can
> see that the two least significant bits are checked. Still replace
>
> i + 1
>
> by
>
> 1 << i
>
> which shouldn't make a relevant difference to compiler and compiled
> code, but is easier to understand for a human code reader.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
You need to submit this to ACPICA project first.
Documentation/driver-api/acpi/linuxized-acpica.rst explains the process.
Refer [1] for details for similar suggestion by Rafael.
--
Regards,
Sudeep
[1] https://lore.kernel.org/all/CAJZ5v0gPUBFzuFiRWW8KHAwB1Agy+Le=CWuRD0RTr4MkNeEmQw@xxxxxxxxxxxxxx
