On Thu, Mar 23, 2023 at 02:31:04PM +0000, Russell King (Oracle) wrote: > On Thu, Mar 23, 2023 at 04:03:05PM +0200, Andy Shevchenko wrote: > > On Wed, Mar 22, 2023 at 12:00:06PM +0000, Russell King (Oracle) wrote: ... > > > + struct fwnode_handle *fwnode; > > > > > + fwnode = of_fwnode_handle(dp->dn); > > > > const struct fwnode_handle *fwnode = of_fwnode_handle(dp->dn); > > > > ? > > Why const? Do you modify its content on the fly? For fwnode as a basic object type we want to reduce the scope of the possible modifications. If you don't modify and APIs you call do not require non-const object, use const for fwnode. ... > Why do you want it on one line? The code as written conforms to > netdev coding standards which as you well know are different from > the rest of the kernel. This is up to you. I don't care. -- With Best Regards, Andy Shevchenko
