> > +static const struct {
> > + const char *name;
> > + const char * const *group_names;
>
> Use this instead
> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-
> pinctrl.git/tree/include/linux/pinctrl/pinctrl.h?h=devel#n215
> and this
> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-
> pinctrl.git/tree/include/linux/pinctrl/pinctrl.h?h=devel#n222
>
> > +} mlxbf_pmx_funcs[] = {
>
> > +};
so copy that struct definition and macro to my driver? (I don’t see these code changes in master)
>
> > + /* This resource is shared so use devm_ioremap */
>
> Can you elaborate on who actually requests the region? And why is it not
> _this_ driver?
This resource is shared with the gpio-mlxbf3.c driver. The gpio-mlxbf3.c driver does not access the same offsets as the pinctrl-mlxbf3.c driver, but it accesses several other registers offsets in between.
