Jonathan Cameron wrote: > > > > > > > /* > > > * If device_attach() fails the range may still be active via > > > * the platform-firmware memory map, otherwise the driver for > > > * regions is local to this file, so driver matching can't fail > > > + * and hence device_attach() cannot return 1. > > > > > > //very much not obvious otherwise to anyone who isn't far too familiar with device_attach() > > > > Hence the comment? Not sure what else can be said here about why > > device_attach() < 0 is a sufficient check. > > I'd just add the bit I added above that calls out the condition you are > describing is indicated by a return of 1. Got it.