On Tue, Feb 14, 2023 at 3:52 PM Limonciello, Mario <Mario.Limonciello@xxxxxxx> wrote: > > [AMD Official Use Only - General] > > > > > -----Original Message----- > > From: Rafael J. Wysocki <rafael@xxxxxxxxxx> > > Sent: Tuesday, February 14, 2023 08:49 > > To: Limonciello, Mario <Mario.Limonciello@xxxxxxx> > > Cc: rafael@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; dbilios@xxxxxxxx; Len > > Brown <lenb@xxxxxxxxxx>; linux-acpi@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH 2/2] ACPI: x86: Add more systems to quirk list for forcing > > StorageD3Enable > > > > On Mon, Feb 13, 2023 at 10:35 PM Mario Limonciello > > <mario.limonciello@xxxxxxx> wrote: > > > > > > commit 018d6711c26e4 ("ACPI: x86: Add a quirk for Dell Inspiron 14 2-in-1 > > > for StorageD3Enable") introduced a quirk to allow a system with ambiguous > > > use of _ADR 0 to force StorageD3Enable. > > > > > > It is reported that Vostro 5626 suffers same symptoms. Add this other > > > system to the list as well. > > > > > > Suggested-by: dbilios@xxxxxxxx > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=217003 > > > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> > > > > Can you please combine these two patches into one? > > > > Or at least make the subjects differ? > > I left them split so that we could revert one if the BIOS is fixed on one > in the future. Happy to respin with separate subjects. > > But before I respin; something else I want to offer as an idea to avoid this list > growing. > > They all use the same CPU. So we could just add the CPU model that all of these > use to the force StorageD3Enable list and take out the whole (growing) list. Well, I'd rather do this, but in the next cycle. > Which way would you prefer? For this merge window, please respin the current patch series and make the changes as per the above early after 6.3-rc1. It may be still necessary to pull them into 6.3-rc later, if more instances are reported or discovered, but we'll see.