On Mon, Feb 13, 2023 at 05:26:13PM +0000, Jessica Clarke wrote: > On 30 Jan 2023, at 18:22, Sunil V L <sunilvl@xxxxxxxxxxxxxxxx> wrote: > > > > When CONFIG_PCI is enabled, ACPI core expects few arch > > functions related to PCI. Add those functions so that > > ACPI core gets build. These are levraged from arm64. > > Presumably this is pretty generic and applies to anything without x86 > weirdness. Copying all this supposedly architecture specific code > that’s really generic seems like bad practice to me as an outsider. > Should this not be unifying the two in a shared location as has been > done for other subsystems? Make sense. Let me add these functions in a common location pci-acpi.c for RISC-V. Other architectures can migrate to this in future. Thanks, Sunil
