On Sun, 2023-02-05 at 17:02 -0800, Dan Williams wrote:
> In preparation for a new region mode, do not, for example, allow
> 'ram' decoders to be assigned to 'pmem' regions and vice versa.
>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> ---
> drivers/cxl/core/region.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Looks good,
Reviewed-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>
>
> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> index c9e7f05caa0f..53d6dbe4de6d 100644
> --- a/drivers/cxl/core/region.c
> +++ b/drivers/cxl/core/region.c
> @@ -1217,6 +1217,12 @@ static int cxl_region_attach(struct cxl_region *cxlr,
> struct cxl_dport *dport;
> int i, rc = -ENXIO;
>
> + if (cxled->mode != cxlr->mode) {
> + dev_dbg(&cxlr->dev, "%s region mode: %d mismatch: %d\n",
> + dev_name(&cxled->cxld.dev), cxlr->mode, cxled->mode);
> + return -EINVAL;
> + }
> +
> if (cxled->mode == CXL_DECODER_DEAD) {
> dev_dbg(&cxlr->dev, "%s dead\n", dev_name(&cxled->cxld.dev));
> return -ENODEV;
>
