On Mon, Jan 30, 2023 at 11:52:05PM +0530, Sunil V L wrote: > Few header files are required unconditionally by ACPI core. nit: A few. Without the article this has a different meaning. > So add empty header files for now and update it when needed. s/ and update it when needed// ;) > > Signed-off-by: Sunil V L <sunilvl@xxxxxxxxxxxxxxxx> > --- > arch/riscv/include/asm/acenv.h | 17 +++++++++++++++++ > arch/riscv/include/asm/cpu.h | 9 +++++++++ > 2 files changed, 26 insertions(+) > create mode 100644 arch/riscv/include/asm/acenv.h > create mode 100644 arch/riscv/include/asm/cpu.h > > diff --git a/arch/riscv/include/asm/acenv.h b/arch/riscv/include/asm/acenv.h > new file mode 100644 > index 000000000000..bbc38ecdf753 > --- /dev/null > +++ b/arch/riscv/include/asm/acenv.h > @@ -0,0 +1,17 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * RISC-V specific ACPICA environments and implementation > + * > + * Copyright (C) 2014, Linaro Ltd. > + * Author: Hanjun Guo <hanjun.guo@xxxxxxxxxx> > + * Author: Graeme Gregory <graeme.gregory@xxxxxxxxxx> > + * Copyright (C) 2023, Ventana Micro Systems Inc. > + * Author: Sunil V L <sunilvl@xxxxxxxxxxxxxxxx> More out of idle curiosity than anything else, but what, may I ask, is copyrightable about 2 empty files? Triply so given there are !3! contributors to said empty file! > + */ > + > +#ifndef _ASM_ACENV_H > +#define _ASM_ACENV_H > + > +/* It is required unconditionally by ACPI core, update it when needed. */ How come this file gets a comment and the other doesn't? Also the comment doesn't really make much sense to me in a vacuum, and ideally would read like: "This header is required unconditionally by the ACPI core" That is, if a comment is really even needed. Cheers, Conor. > + > +#endif /* _ASM_ACENV_H */ > diff --git a/arch/riscv/include/asm/cpu.h b/arch/riscv/include/asm/cpu.h > new file mode 100644 > index 000000000000..51ec1a89a7a9 > --- /dev/null > +++ b/arch/riscv/include/asm/cpu.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (C) 2014 ARM Ltd. > + * Copyright (C) 2023 Ventana Micro Systems Inc. > + */ > +#ifndef __ASM_CPU_H > +#define __ASM_CPU_H > + > +#endif /* __ASM_CPU_H */ > -- > 2.38.0 >
Attachment:
signature.asc
Description: PGP signature
