On Tue, Feb 7, 2023 at 7:28 AM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > Hi, > > On Mon, Feb 6, 2023 at 5:42 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote: > > > > Naresh, Tony, Abel, Geert, Dmitry, Maxim(s), Miquel, Luca, Doug, Martin, > > Jean-Philippe, > > > > Can I get your Tested-by's for this v3 series please? > > > > Vladimir, > > > > Ccing you because DSA's and fw_devlink have known/existing problems > > (still in my TODOs to fix). But I want to make sure this series doesn't > > cause additional problems for DSA. > > > > All, > > > > This patch series improves fw_devlink in the following ways: > > > > 1. It no longer cares about a fwnode having a "compatible" property. It > > figures this out more dynamically. The only expectation is that > > fwnodes that are converted to devices actually get probed by a driver > > for the dependencies to be enforced correctly. > > > > 2. Finer grained dependency tracking. fw_devlink will now create device > > links from the consumer to the actual resource's device (if it has one, > > Eg: gpio_device) instead of the parent supplier device. This improves > > things like async suspend/resume ordering, potentially remove the need > > for frameworks to create device links, more parallelized async probing, > > and better sync_state() tracking. > > > > 3. Handle hardware/software quirks where a child firmware node gets > > populated as a device before its parent firmware node AND actually > > supplies a non-optional resource to the parent firmware node's > > device. > > > > 4. Way more robust at cycle handling (see patch for the insane cases). > > > > 5. Stops depending on OF_POPULATED to figure out some corner cases. > > > > 6. Simplifies the work that needs to be done by the firmware specific > > code. > > > > The v3 series has gone through my usual testing on my end and looks good > > to me. > > > > Thanks, > > Saravana > > > > [1] - https://lore.kernel.org/lkml/20220810060040.321697-1-saravanak@xxxxxxxxxx/ > > [2] - https://lore.kernel.org/lkml/CAGETcx-JUV1nj8wBJrTPfyvM7=Mre5j_vkVmZojeiumUGG6QZQ@xxxxxxxxxxxxxx/ > > > > v1 -> v2: > > - Fixed Patch 1 to handle a corner case discussed in [2]. > > - New patch 10 to handle "fsl,imx8mq-gpc" being initialized by 2 drivers. > > - New patch 11 to add fw_devlink support for SCMI devices. > > > > v2 -> v3: > > - Addressed most of Andy's comments in v2 > > - Added Colin and Sudeep's Tested-by for the series (except the imx and > > renesas patches) > > - Added Sudeep's Acked-by for the scmi patch. > > - Added Geert's Reviewed-by for the renesas patch. > > - Fixed gpiolib crash reported by Naresh. > > - Patch 6: Fix __fwnode_links_move_consumers() to preserve fwnode link flags. > > - New Patch 12 to fix nvmem-cells issue reported by Maxim(s)/Miquel. > > - Deleted some stale function doc in Patch 8 > > > > Cc: Abel Vesa <abel.vesa@xxxxxxxxxx> > > Cc: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx> > > Cc: Tony Lindgren <tony@xxxxxxxxxxx> > > Cc: Sudeep Holla <sudeep.holla@xxxxxxx> > > Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > Cc: John Stultz <jstultz@xxxxxxxxxx> > > Cc: Doug Anderson <dianders@xxxxxxxxxxxx> > > Cc: Guenter Roeck <linux@xxxxxxxxxxxx> > > Cc: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > Cc: Maxim Kiselev <bigunclemax@xxxxxxxxx> > > Cc: Maxim Kochetkov <fido_max@xxxxxxxx> > > Cc: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > > Cc: Luca Weiss <luca.weiss@xxxxxxxxxxxxx> > > Cc: Colin Foster <colin.foster@xxxxxxxxxxxxxxxx> > > Cc: Martin Kepplinger <martin.kepplinger@xxxxxxx> > > Cc: Jean-Philippe Brucker <jpb@xxxxxxxxxx> > > Cc: Vladimir Oltean <vladimir.oltean@xxxxxxx> > > > > Saravana Kannan (12): > > driver core: fw_devlink: Don't purge child fwnode's consumer links > > driver core: fw_devlink: Improve check for fwnode with no > > device/driver > > soc: renesas: Move away from using OF_POPULATED for fw_devlink > > gpiolib: Clear the gpio_device's fwnode initialized flag before adding > > driver core: fw_devlink: Add DL_FLAG_CYCLE support to device links > > driver core: fw_devlink: Allow marking a fwnode link as being part of > > a cycle > > driver core: fw_devlink: Consolidate device link flag computation > > driver core: fw_devlink: Make cycle detection more robust > > of: property: Simplify of_link_to_phandle() > > irqchip/irq-imx-gpcv2: Mark fwnode device as not initialized > > firmware: arm_scmi: Set fwnode for the scmi_device > > mtd: mtdpart: Don't create platform device that'll never probe > > I tested the whole series together on several devices. I tried to test > on a wide variety since previous versions had broken due to all the > dependency cycles in the display and some of these devices used > different components in their display pipeline. I didn't do massive > testing but did confirm that basic devices came up, including display. > > Devices tested with your v3 applied atop v6.2-rc7-11-g05ecb680708a: > > * sc7180-trogdor-lazor (with ps8640 bridge), which had failed to bring > up the display on v2. > > * sc7180-trogdor-lazor (with sn65dsi86 bridge) > > * sc7180-trogdor-pazquel (with sn65dsi86 bridge) > > * sc7180-trogdor-homestar (with ps8640 bridge) > > * sc7180-trogdor-wormdingler > > * sc7280-herobrine-villager > > Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx> Thanks a lot for all this testing and helping me debug the ps8640 issue Doug! -Saravana
