On 06/02/2023 17:08, Rafael J. Wysocki wrote:
On Fri, Feb 3, 2023 at 6:59 PM Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote:
Some drivers are declaring a thermal zone without any thermal trip
points.
On the other side, we are introducing the function
thermal_zone_device_register_with_trips() which provides an array of
generic thermal trip points. When all the drivers will be converted to
the generic trip points, keeping two functions will be useless.
Most of the drivers are now using
thermal_zone_device_register_with_trips() with the generic trip
points. As soon as the remaining drivers are merged, the
thermal_zone_device_register_with_trips() will be renamed to
thermal_zone_device_register().
So why is this the first time I'm learning about this plan?
Well it is not a plan, it looked purely logical to me that the
_with_trips variant was added to support the generic trip points in
addition to the specific trips. As soon as all the drivers are
converted, there is no need to have these two functions anymore and we
can fall back to the previous name (or a shorter one).
Obviously this renaming can only happen if there are no more user of
the thermal_zone_device_register() function.
This change uses thermal_zone_device_register_with_trips() with a NULL
parameter for the trip point array instead of
thermal_zone_device_register().
And later it will be renamed to thermal_zone_device_register() again?
Yes, that was the idea, unify the name and then use a cocci script to
rename them all.
Can we just stop confusing people this way?
What would be wrong with changing both
thermal_zone_device_register_with_trips() and
thermal_zone_device_register() together when we are ready? And why
can't the both be replaced with something line thermal_zone_register()
doing all of the necessary things in one go? Why do we have to make
confusing and redundant changes?
For me the result will be the same, if you prefer to wait for all the
drivers to be converted then it is fine for me.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
