Hi Daniel,
daniel.lezcano@xxxxxxxxxx wrote on Fri, 3 Feb 2023 18:58:31 +0100:
> Some drivers are declaring a thermal zone without any thermal trip
> points.
>
> On the other side, we are introducing the function
> thermal_zone_device_register_with_trips() which provides an array of
> generic thermal trip points. When all the drivers will be converted to
> the generic trip points, keeping two functions will be useless.
>
> Most of the drivers are now using
> thermal_zone_device_register_with_trips() with the generic trip
> points. As soon as the remaining drivers are merged, the
> thermal_zone_device_register_with_trips() will be renamed to
> thermal_zone_device_register().
>
> Obviously this renaming can only happen if there are no more user of
> the thermal_zone_device_register() function.
>
> This change uses thermal_zone_device_register_with_trips() with a NULL
> parameter for the trip point array instead of
> thermal_zone_device_register().
>
> No functional change intended.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> ---
> drivers/power/supply/power_supply_core.c | 2 +-
> drivers/thermal/armada_thermal.c | 4 ++--
> drivers/thermal/dove_thermal.c | 4 ++--
> drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 6 +++---
> drivers/thermal/kirkwood_thermal.c | 4 ++--
> drivers/thermal/spear_thermal.c | 5 +++--
> 6 files changed, 13 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c
> index 7c790c41e2fe..208a849a71d9 100644
> --- a/drivers/power/supply/power_supply_core.c
> +++ b/drivers/power/supply/power_supply_core.c
> @@ -1166,7 +1166,7 @@ static int psy_register_thermal(struct power_supply *psy)
>
> /* Register battery zone device psy reports temperature */
> if (psy_has_property(psy->desc, POWER_SUPPLY_PROP_TEMP)) {
> - psy->tzd = thermal_zone_device_register(psy->desc->name,
> + psy->tzd = thermal_zone_device_register_with_trips(psy->desc->name, NULL,
> 0, 0, psy, &psy_tzd_ops, NULL, 0, 0);
> if (IS_ERR(psy->tzd))
> return PTR_ERR(psy->tzd);
> diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
> index 99e86484a55c..83a4080bffc7 100644
> --- a/drivers/thermal/armada_thermal.c
> +++ b/drivers/thermal/armada_thermal.c
> @@ -856,8 +856,8 @@ static int armada_thermal_probe(struct platform_device *pdev)
> /* Wait the sensors to be valid */
> armada_wait_sensor_validity(priv);
>
> - tz = thermal_zone_device_register(priv->zone_name, 0, 0, priv,
> - &legacy_ops, NULL, 0, 0);
> + tz = thermal_zone_device_register_with_trips(priv->zone_name, NULL, 0, 0, priv,
> + &legacy_ops, NULL, 0, 0);
> if (IS_ERR(tz)) {
> dev_err(&pdev->dev,
> "Failed to register thermal zone device\n");
Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
Thanks,
Miquèl
