On Thu, Feb 2, 2023 at 2:04 AM Marty E. Plummer <hanetzer@xxxxxxxxxxxxx> wrote: > > From: "Rafael J. Wysocki" <rafael@xxxxxxxxxx> > > > On Wed, Feb 1, 2023 at 12:38 AM Pedro Falcato <pedro.falcato@xxxxxxxxx> wrote: > > > > > > Make custom_method keep its own per-file-open state instead of global > > > state in order to avoid race conditions[1] and other possible conflicts > > > with other concurrent users. > > > > > > Link: https://lore.kernel.org/linux-acpi/20221227063335.61474-1-zh.nvgt@xxxxxxxxx/ # [1] > > > Reported-by: Hang Zhang <zh.nvgt@xxxxxxxxx> > > > Cc: Swift Geek <swiftgeek@xxxxxxxxx> > > > Signed-off-by: Pedro Falcato <pedro.falcato@xxxxxxxxx> > > > --- > > > This patch addresses Hang's problems plus the ones raised by Rafael in his review (see link above). > > > https://lore.kernel.org/lkml/2667007.mvXUDI8C0e@kreacher/ was submitted but since there were still people > > > that wanted this feature, I took my time to write up a patch that should fix the issues. > > > Hopefully the linux-acpi maintainers have not decided to remove custom_method just yet. > > > > Well, thanks for the patch, but yes, they have. Sorry. > > Honestly, I think that's a bit of a cop out. This is git. git revert exists, > and you're crippling the abilities of quite a lot of coreboot/etc development. Perhaps they can try to use the ACPI debugger that's in the kernel now instead of a known-broken interface?
