Re: [PATCH v1 8/8] thermal: intel: intel_pch: Refer to thermal zone name directly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 31/01/2023 20:20, Rafael J. Wysocki wrote:
On Tue, Jan 31, 2023 at 5:02 PM Daniel Lezcano
<daniel.lezcano@xxxxxxxxxx> wrote:

On 30/01/2023 20:07, Rafael J. Wysocki wrote:
From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

Make intel_pch_thermal_probe() use a const char pointer instead of
a struct board_info one for accessing the thermal zone name.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
---

BTW, Srinivas, I'm wondering if user space would be terribly confused by
changing this driver to use "Intel PCH" as the thermal zone name of all
of the supported platforms?

---
   drivers/thermal/intel/intel_pch_thermal.c |    6 +++---
   1 file changed, 3 insertions(+), 3 deletions(-)

Index: linux-pm/drivers/thermal/intel/intel_pch_thermal.c
===================================================================
--- linux-pm.orig/drivers/thermal/intel/intel_pch_thermal.c
+++ linux-pm/drivers/thermal/intel/intel_pch_thermal.c
@@ -175,7 +175,7 @@ static int intel_pch_thermal_probe(struc
                                  const struct pci_device_id *id)
   {
       enum pch_board_ids board_id = id->driver_data;
-     const struct board_info *bi = &board_info[board_id];
+     const char *zone_name = board_info[board_id].name;

Assuming you will change 'board_info[board_id].name' by
'board_info[board_id]'

Hmm, why would that be required?

I meant board_names[board_id] (related to the change proposed in the patch replacement below)

Acked-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>

Anyway, though, I'm planning to use this replacement patch instead of
the $subject one:

https://lore.kernel.org/linux-pm/12166249.O9o76ZdvQC@kreacher/

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux