Hi Saravana, On Mon, Jan 30, 2023 at 03:03:01PM -0800, Saravana Kannan wrote: > On Mon, Jan 30, 2023 at 12:56 AM Naresh Kamboju > <naresh.kamboju@xxxxxxxxxx> wrote: > > > > Build test pass on arm, arm64, i386, mips, parisc, powerpc, riscv, s390, sh, > > sparc and x86_64. > > > > Boot and LTP smoke pass on qemu-arm64, qemu-armv7, qemu-i386 and qemu-x86_64. > > Boot failed on FVP. > > > > Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx> > > > > Please refer following link for details of testing. > > FVP boot log failed. > > https://qa-reports.linaro.org/~anders.roxell/linux-mainline-patches/build/lore_kernel_org_linux-devicetree_20230127001141_407071-1-saravanak_google_com/testrun/14389034/suite/boot/test/gcc-12-lkftconfig-64k_page_size/details/ > > Sudeep pointed me to what the issue might be. But it's strange that > you are hitting an issue now. I'm pretty sure I haven't changed this > part since v1. I'd also expect the limited assumptions I made to have > not been affected between v1 and v2. > Sorry I hadn't seen or tested v1. FYI The fwnode non-NULL check as in your nvmem diff/suggestion and the diff I replied on the gpiolib patch thread fixes the issues. > Anyway, I'll look at this and fix it in v3. > If you add that fwnode check, feel free to add my tested by. -- Regards, Sudeep