On Fri, Feb 15, 2008 at 11:38:59AM -0800, Yinghai Lu wrote: > On Fri, Feb 15, 2008 at 2:19 AM, Frans Pop <elendil@xxxxxxxxx> wrote: > > On Friday 15 February 2008, Greg KH wrote: > > > I swear someone sent this patch in before. Can you try this one below, > > > there seems to be an imbalance with kobject_get and _put. > > > > I did remember seeing this patch before [1] and can confirm that it does > > indeed fix the issue: with this patch applied to 2.6.25 git head my system > > powers off correctly. > > > > [1] See http://lkml.org/lkml/2008/2/8/342; also added to #9960. > > > > > > > > > --- > > > drivers/cpufreq/cpufreq.c | 8 -------- > > > 1 file changed, 8 deletions(-) > > > > > > --- a/drivers/cpufreq/cpufreq.c > > > +++ b/drivers/cpufreq/cpufreq.c > > > @@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct > > > } > > > #endif > > > > > > - > > > - if (!kobject_get(&data->kobj)) { > > > - spin_unlock_irqrestore(&cpufreq_driver_lock, flags); > > > - cpufreq_debug_enable_ratelimit(); > > > - unlock_policy_rwsem_write(cpu); > > > - return -EFAULT; > > > - } > > > - > > > #ifdef CONFIG_SMP > > > > > > #ifdef CONFIG_HOTPLUG_CPU > > > > > > confirmed, with this patch, i still need disable CONFIG_DETECT_SOFTLOCKUP Great, thanks for testing and letting us know. greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
