Hi Rafael, On 19/01/2023 14:15, Rafael J. Wysocki wrote: [ ... ]
+static int thermal_acpi_get_temperature_object(struct acpi_device *adev, + char *object, int *temperature)So this would become thermal_acpi_get_temp_object(). or even thermal_acpi_get_temp() because it really returns the temperature value. I also don't particularly like returning values via pointers, which is entirely avoidable here, because the temperature value obtained from the ACPI control methods must be a positive number. So I would make it static int thermal_acpi_get_temp(struct acpi_device *adev, char *object_name) {
We are converting decikelvin -> millicelsius. Even it is very unlikely, the result could be less than zero (eg. -1°C). We won't be able to differentiate -ENODATA with a negative value, no ?
In the future, it is possible we will have to deal with cold trip points in order to warm a board. May be we should don't care for now ?
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
