On Tue, Jan 17, 2023 at 02:22:39PM +0200, Sakari Ailus wrote: > Add SOFTWARE_NODE() macro in order to make defining software nodes look > nicer. This is analogous to different PROPERTY_ENTRY_*() macros for > defining properties. ... > +#define SOFTWARE_NODE(_name_, _properties_, _parent_) \ > + (struct software_node) { \ > + .name = _name_, \ > + .properties = _properties_, \ > + .parent = _parent_, \ Missed parentheses? > + } Otherwise LGTM. -- With Best Regards, Andy Shevchenko