On Wed, Jan 11, 2023 at 12:24 AM Borislav Petkov <bp@xxxxxxxxx> wrote:
>
> On Tue, Jan 10, 2023 at 05:43:41PM -0500, James Puthukattukaran wrote:
> > Adding others that I missed on my first email.
> >
> > James
> >
> > On 12/22/22 13:26, James Puthukattukaran wrote:
> > > Extending commit aa06e20f1be6 ("x86/ACPI: Don't add CPUs that are not
> > > online capable") to include acpi_parse_x2apic as well.
>
> This doesn't look like an extension to some existing commit but like a separate
> fix.
>
> > > There is a check for invalid apicid; however, there are BIOS FW with madt
> > > version >= 5 support that do not bother setting apic id to an invalid value
> > > since they assume the OS will check the enabled and online capable flags.
>
> Which BIOSes are those?
>
> Also, I'm no BIOS guy but I don't see you checking MADT version anywhere?
>
> > > Signed-off-by: James Puthukattukaran<james.puthukattukaran@xxxxxxxxxx>
> > > Reported-by: Benjamin Fuller<ben.fuller@xxxxxxxxxx>
> > >
> > > v2 : use 'enabled' local variable. Also fix checkpatch.pl catches
> > > v3 : updates as per Rafael's comments
>
> Yah, I'd like for Rafael to decide what to do here...
I've just sent my comments to the patch, but you have not been CCed, sorry.
IMO the MADT version should be checked too and I would like to have at
least one example of a platform affected by this problem in the
changelog.
