Hello,
[expanded Cc: for the acpi topic]
On Sun, Dec 11, 2022 at 11:14:35PM +0100, Jean Delvare wrote:
> Hallo Uwe,
>
> On Sun, 11 Dec 2022 21:56:48 +0100, Uwe Kleine-König wrote:
> > On Mon, Nov 21, 2022 at 05:09:11PM +0100, Jean Delvare wrote:
> > > --- linux-6.0.orig/drivers/media/rc/pwm-ir-tx.c
> > > +++ linux-6.0/drivers/media/rc/pwm-ir-tx.c
> > > @@ -120,7 +120,7 @@ static struct platform_driver pwm_ir_dri
> > > .probe = pwm_ir_probe,
> > > .driver = {
> > > .name = DRIVER_NAME,
> > > - .of_match_table = of_match_ptr(pwm_ir_of_match),
> > > + .of_match_table = pwm_ir_of_match,
> > > },
> > > };
> > > module_platform_driver(pwm_ir_driver);
> >
> > That hunk makes sense even without the Kconfig change. ACPI makes use of
> > .of_match_table, so
> >
> > .of_match_table = of_match_ptr(pwm_ir_of_match),
> >
> > is (almost?) always wrong.
>
> Should we just get rid of this macro altogether then?
>
> (Somehow I have a strange feeling that we already had this
> discussion...)
Might be. But for me this is only second hand knowledge, too. Maybe
someone of the new recipents in this thread feels competent to comment
here?!
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
