On Thu, Dec 8, 2022 at 3:00 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Thu, Dec 8, 2022 at 1:02 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: ... > Side note. We adding a lot of DMI matching information here and there > in the drivers and often it gets duplicated in handful of times, Maybe > at some point we can create a global enum and matching table, let's > say driver/platform/x86/dmi-platforms.c with > include/linux/platform_data/x86/platform.h with global enum of the > platforms? Or even something close to vendor/device API, so you call like /* h */ enum x86_microsoft_platforms ...; int x86_dmi_match(); /* c */ enum x86_microsoft_platforms p; int ret; ret = x86_dmi_match("Microsoft" /* which is defined either as number or string */); if (ret < 0) not found p = ret; -- With Best Regards, Andy Shevchenko