On 07/12/2022 11:32, Andy Shevchenko wrote: > On Wed, Dec 07, 2022 at 03:22:18PM +0400, Miaoqian Lin wrote: >> Use fwnode_handle_put() on the node pointer to release the refcount. >> Change fwnode_handle_node() to fwnode_handle_put(). > Looks correct to me, thanks! > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> And to me too: Reviewed-by: Daniel Scally <djrscally@xxxxxxxxx> > >> Fixes: 233872585de1 ("device property: Add fwnode_get_next_parent()") >> Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx> >> --- >> drivers/base/property.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/base/property.c b/drivers/base/property.c >> index 2a5a37fcd998..daa1e379762b 100644 >> --- a/drivers/base/property.c >> +++ b/drivers/base/property.c >> @@ -601,7 +601,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_parent); >> * node's parents. >> * >> * Returns a node pointer with refcount incremented, use >> - * fwnode_handle_node() on it when done. >> + * fwnode_handle_put() on it when done. >> */ >> struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode) >> { >> -- >> 2.25.1 >>