On Wed, Nov 09, 2022 at 11:32:31AM -0800, Dmitry Torokhov wrote: > On Wed, Nov 09, 2022 at 01:29:41PM +0200, Andy Shevchenko wrote: > > On Tue, Nov 08, 2022 at 04:26:45PM -0800, Dmitry Torokhov wrote: ... > > Thank for an update! > > > > I have almost nothing serious except two nit-picks I think we can address: > > - dropping const qualifier for no (?) reason > > - having a superfluous check and extra dev_dbg() > > > > If you are are going to address them, feel free to add my Rb tag to > > the patches 5 & 6. > > Thank you for the reviews. I addressed most of your comments, but > because I still left the check you were concerned about in I'd like an > explicit reviewed-by on the v3 if you OK giving it. I gave for patch 6 and for patch 5 I still think we can get rid of the check. -- With Best Regards, Andy Shevchenko
