On Thu, Nov 10, 2022 at 09:50:32AM +0800, Huisong Li wrote: > Currently, the name of platform interrupt bit macro, ACPI_PCCT_DOORBELL, > is not very appropriate. The doorbell is generally considered as an action > when send mailbox data. Actually, the macro value comes from Platform > Interrupt in Platform Communications Channel Global Flags. If the bit is > '1', it means that the platform is capable of generating an interrupt to > indicate completion of a command. > This is touching ACPICA header file, so it must be submitted to ACPICA separately following the guidelines in the github and imported into the kernel. However, I don't see any point in this change. Yes the language "doorbell" is not used in this particular context in the spec, but it is implicit from other parts. I am not opposing the change though if Rafael is OK and ACPICA project accepts it. -- Regards, Sudeep